Commons:User scripts/reports/MediaWiki:Gadget-ImageAnnotator.js

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

This is the report page for MediaWiki:Gadget-ImageAnnotator.js. It is bot-maintained. All manual changes might be overwritten.

jshint[edit]

  1. ISSUE: line 435 character 43: Use '===' to compare with 'null'. - Evidence: if ( text == null ) { return ''; }
  2. ISSUE: line 738 character 56: Use '!==' to compare with 'null'. - Evidence: if ( self.note.content != null ) {
  3. ISSUE: line 1024 character 120: Don't make functions within a loop. - Evidence: !Array.exists( this.annotations, function ( note ) { return note.model.id == id; } )
  4. ISSUE: line 1040 character 69: Use '===' to compare with '0'. - Evidence: if ( !this.main_div || this.main_div.length == 0 ) { this.main_div = null; } else { this.main_div = this.main_div[ 0 ]; }
  5. ISSUE: line 1087 character 27: Don't make functions within a loop. - Evidence: } );
  6. ISSUE: line 1235 character 33: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function intersect_rectangles( a, b ) {
  7. ISSUE: line 1265 character 75: Use '!==' to compare with 'null'. - Evidence: display !== 'none' && display != null &&
  8. ISSUE: line 1407 character 59: Use '!==' to compare with 'null'. - Evidence: if ( !config || ImageAnnotator_config != null ) { return; }
  9. ISSUE: line 1423 character 66: Use '!==' to compare with 'null'. - Evidence: self.haveAjax = ( LAPI.Ajax.getRequest() != null );
  10. ISSUE: line 1871 character 33: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function get_size( info ) {
  11. ISSUE: line 1883 character 52: Use '!==' to compare with '0'. - Evidence: if ( i != 0 || !self.may_edit || !info.protection || mw.config.get( 'wgNamespaceNumber' ) != 6 ) { return; }
  12. ISSUE: line 2009 character 44: 'item' is already defined. - Evidence: for ( var item in self.defaults ) {
  13. ISSUE: line 2116 character 64: Use '!==' to compare with 'null'. - Evidence: IA.haveAjax = ( LAPI.Ajax.getRequest() != null );
  14. ISSUE: line 2236 character 25: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function track( evt ) {
  15. ISSUE: line 2264 character 25: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function pause( evt ) {
  16. ISSUE: line 2270 character 25: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function resume( evt ) {
  17. ISSUE: line 2280 character 25: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function stop_tracking( evt ) {
  18. ISSUE: line 2327 character 25: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function start_tracking( evt ) {
  19. ISSUE: line 2360 character 25: Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function. - Evidence: function add_new( evt ) {
  20. ISSUE: line 2626 character 35: Don't make functions within a loop. - Evidence: } );
  21. ISSUE: line 3080 character 70: Use '!==' to compare with 'null'. - Evidence: self.haveAjax = ( LAPI.Ajax.getRequest() != null );