Template talk:Extracted from/layout

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

Behaves differently[edit]

@Alno: this template now behaves differently. Using {{Extracted from|image.jpg|3=}} would previously result in no thumbnail, but now 3= is ignored. It disables the thumbnail when entering something for 3, but I don't want replacement text. For my personal case I fixed it by using 3=  but other files pages may be affected. - Alexis Jazz ping plz 05:50, 24 January 2019 (UTC)[reply]

@Alno: see https://commons.wikimedia.org/w/index.php?title=Template:Extracted_from_deleted&oldid=332210048 (which used to work) and how I fixed it for that template. But there are other pages that were depending on this behaviour. - Alexis Jazz ping plz 09:24, 24 January 2019 (UTC)[reply]

@Alexis Jazz: : thanks for your notifications :)
Actually, the new behaviour seems to me more logical, as the content of the third parameter is empty when you write something like {{...|3=}}. So we have 3 cases:
  • third param is not even mentionned => we show the image
  • third param is mentionned but its content is empty (this is the difficult part as I don't find how to test this) => we don't show the image nor display any text
  • third param is mentionnend and has a text value => we just show the param's contents
I think this could maybe be fixed in the main page of the template (template:extracted from), or else in the language subpages (/fr, /nl, etc.)
Please let me some time to fix this...
Best regards, -- AlNo (discuter/talk/hablar/falar) 09:43, 24 January 2019 (UTC)[reply]
I also looked at the usages made of the template, it seems that only a few other templates are using it... All the other usages are directly from images. Maybe it will be simpler to fix the problem in the other templates? I don't know yet. -- AlNo (discuter/talk/hablar/falar) 09:58, 24 January 2019 (UTC)[reply]
@Alno: there are also some images that use the empty parameter like File:ALS animal models.jpg and File:Ammy Virk.jpg but I'm not sure how to find all of them. - Alexis Jazz ping plz 10:05, 24 January 2019 (UTC)[reply]