Commons:Bots/Requests/SignBot

SignBot (talk · contribs)

Operator: Zhuyifei1999 (talk · contributions · Statistics · Recent activity · block log · User rights log · uploads · Global account information) (assign permissions)

Bot's tasks for which permission is being sought: Unsigned bot, Technical details:

• Using stream.wikimedia.org, get the recent changes feed.  Done
• Ignore edits with "!nosign!" in comment, and edits not in any talk namespace or commons namespace.  Done
• Check for user opt-in/out.
  • {{YesAutosign}} -> opt-in  Done
  • {{NoAutosign}} -> opt-out  Done
  • 800 editcount -> opt-out  Done
  • default -> opt-in
• If the page is in commons namespace, check whether the page is discussion or not
  • __NEWSECTIONLINK__  Done
  • Some regexes for other pages  Doing…
  • a sandbox page  Done -- User_talk:SignBot/sandbox
• Check for talk page templates that do not need signatures
  • {{Published}}  Done
  • {{Speedy}}  Done
  • More?  Doing…
• Analyse the diff: find the last non-empty, non-heading, non-category-link-only, functional inserted line  Done
  • And not lines in tables  Partially done
  • And if the edited talk page is the editor's own talk page (strict), and a template is added, ignore the edit  Done
• Fine if the line contains a link to the user's userpage (the signature)  Done
  • Maybe also check for undated signatures?  Don't worth the work
• Wait a minute for the user to sign himself.  Done
  • Exclusion list?  Probably not
• Find the line and add the {{Unsigned}}, save.  Done
• Notify the user if 3 unsigned comments are added in the same day  Done

Automatic or manually assisted: Automatic unsupervised

Edit type (e.g. Continuous, daily, one time run): Continuous

Maximum edit rate (e.g. edits per minute): about 6 edits per min (pywikibot max), but this will be extremely rare, unless someone batch commenting without signing.

Bot flag requested: (Y/N): N

Programming language(s): python: pywikibot

Zhuyifei1999 (talk) 10:30, 5 October 2015 (UTC)

Discussion

• Test running --Zhuyifei1999 (talk) 12:01, 5 October 2015 (UTC)
  • There was some issues with anon edits, should be now fixed. Waiting for someone to forget signing --Zhuyifei1999 (talk) 13:22, 5 October 2015 (UTC)
  • False negative on File talk:Pacific Islands Forum Logo.svg, should be fixed. --Zhuyifei1999 (talk) 14:45, 5 October 2015 (UTC)
  • Another on Special:Diff/174619061, seems like a problem with difference engine. Using python difflib seems insufficient for this task.  Finding replacements --Zhuyifei1999 (talk) 07:32, 6 October 2015 (UTC)

    Nope, my bad in coding, fixed --Zhuyifei1999 (talk) 08:21, 6 October 2015 (UTC)

  • One-day test run  Done --Zhuyifei1999 (talk) 12:03, 6 October 2015 (UTC)
•   Useful function. --Steinsplitter (talk) 12:02, 5 October 2015 (UTC)

<3 --Steinsplitter (talk) 13:04, 5 October 2015 (UTC)

Please feel free to do a continuous test run unless objections arise. --Krd 13:48, 6 October 2015 (UTC)

Ok, sure --Zhuyifei1999 (talk) 15:07, 6 October 2015 (UTC)

The bot appearantly don't recognize signatures in the middle of an insertion yet. I'll start next run when that's fixed. --Zhuyifei1999 (talk) 15:38, 6 October 2015 (UTC)

• Looks OK for me, but I think will be good idea to create dedicated (shared?) bot account for this functionality. --EugeneZelenko (talk) 14:09, 6 October 2015 (UTC)

  Hmm. Any suggestions for name (naming is hard)? --Zhuyifei1999 (talk) 15:07, 6 October 2015 (UTC)

  SignBot, SiBot, S~Bot,... --Steinsplitter (talk) 15:26, 6 October 2015 (UTC)

  SignBot looks good. Account created. Test run now running under that account --Zhuyifei1999 (talk) 04:25, 7 October 2015 (UTC)

  Bot flag applied for the test run. --Krd 06:02, 7 October 2015 (UTC)

• I noticed incorrect bot edit summaries when edit summaries were not filled. Example.

  Does bot check if {{Please sign}} was added on user talk page already?

  EugeneZelenko (talk) 14:21, 7 October 2015 (UTC)

  "" are double quotes that are supposed to contain edit summaries. In this case, the edit summary is empty, so "" is added. If it's better without that, it can be easily removed.

  To prevent abusing the bot (never signing comments), it currently does not check whether a {{subst:Please sign}} is already added or not. (See also en:User:SineBot) It will place the message until the user sign every single comment in a 24-hour period so the counter expire. It may get annoying, but the counter requirement of 3 should be enough to prevent most from triggering the message. --Zhuyifei1999 (talk) 15:05, 7 October 2015 (UTC)

• There are some edits that attempts to add categories to a talk page and got classified as unsigned comments. Though such edits seems weird, should they actually get processed by the bot or not? --Zhuyifei1999 (talk) 11:43, 10 October 2015 (UTC)

  I think such edits should be ignored or reverted in case of content categories. --EugeneZelenko (talk) 14:30, 10 October 2015 (UTC)

  They should be ignored now. --Zhuyifei1999 (talk) 10:31, 11 October 2015 (UTC)

• There are some edits that adds lines to a table. The bot now ignores lines beginning with "|" and "{|" to avoid signing these edits. Is there a better algorithm for this? --Zhuyifei1999 (talk) 10:31, 11 October 2015 (UTC)

Maybe you should check if [[User:]] exists. The skip? --Steinsplitter (talk) 10:35, 11 October 2015 (UTC)

??? Rillke use a user talk subpage as his talk page --Zhuyifei1999 (talk) 11:07, 11 October 2015 (UTC)

• There was false positives per INC that the bot signed talk page templates like {{User talk}}, {{Busy}} and {{User:MiszaBot/config}}. I've added a preventive logic that all templates added to the editors' talk pages are assumed decorations. And since it's difficult to find the end of the corresponding template wikitext (parser required), any addition of templates to the their own talk pages force the bot to ignore the edit. Talk pages in other namespaces are unaffected, as I assume those who decorate those are experienced enough that the bot do not trace their edits by default (unless they opt-in). And I don't think it's a good idea to hardcode a ton of talk page decorative templates (babel templates, etc). Note that user talk subpages (like Rillke's talk page) are also unaffected, as I don't think it worth the work to implement that --Zhuyifei1999 (talk) 09:42, 16 October 2015 (UTC)

Sounds reasonable. --Steinsplitter (talk) 09:58, 16 October 2015 (UTC)

---

If there are no objections, I think we should approve request. --EugeneZelenko (talk) 14:20, 22 October 2015 (UTC)

Support approval. Ongoing development can be documented on the user / user talk page. --Krd 06:48, 24 October 2015 (UTC)